fix all pylint warnings, add tests (wip) fix recap

backend/tests/routers/test_products.py

@@ -1,14 +1,19 @@
-import src.products.exceptions as exceptions
 import src.products.service as service
 import tests.factories.products as product_factory
 from fastapi.exceptions import HTTPException
-from src import models
 from src.auth.auth import get_current_user
 from src.main import app
+from src.products import exceptions
 
 
 class TestProducts:
-    def test_get_all(self, client, mocker, mock_session, mock_user):
+    def test_get_all(
+        self,
+        client,
+        mocker,
+        mock_session,
+        mock_user
+    ):
         mock_results = [
             product_factory.product_public_factory(name="test 1", id=1),
             product_factory.product_public_factory(name="test 2", id=2),
@@ -33,7 +38,13 @@ class TestProducts:
             []
         )
 
-    def test_get_all_filters(self, client, mocker, mock_session, mock_user):
+    def test_get_all_filters(
+        self,
+        client,
+        mocker,
+        mock_session,
+        mock_user
+    ):
         mock_results = [
             product_factory.product_public_factory(name="test 2", id=2),
         ]
@@ -60,8 +71,7 @@ class TestProducts:
             self,
             client,
             mocker,
-            mock_session,
-            mock_user):
+        ):
         def unauthorized():
             raise HTTPException(status_code=401)
 
@@ -75,7 +85,12 @@ class TestProducts:
 
         app.dependency_overrides.clear()
 
-    def test_get_one(self, client, mocker, mock_session, mock_user):
+    def test_get_one(
+        self,
+        client,
+        mocker,
+        mock_session,
+    ):
         mock_result = product_factory.product_public_factory(
             name="test 2", id=2)
 
@@ -95,7 +110,12 @@ class TestProducts:
             2
         )
 
-    def test_get_one_notfound(self, client, mocker, mock_session, mock_user):
+    def test_get_one_notfound(
+        self,
+        client,
+        mocker,
+        mock_session,
+    ):
         mock_result = None
         mock = mocker.patch.object(
             service,
@@ -103,7 +123,6 @@ class TestProducts:
             return_value=mock_result
         )
         response = client.get('/api/products/2')
-        response_data = response.json()
         assert response.status_code == 404
         mock.assert_called_once_with(
             mock_session,
@@ -111,11 +130,10 @@ class TestProducts:
         )
 
     def test_get_one_unauthorized(
-            self,
-            client,
-            mocker,
-            mock_session,
-            mock_user):
+        self,
+        client,
+        mocker,
+    ):
         def unauthorized():
             raise HTTPException(status_code=401)
 
@@ -129,7 +147,12 @@ class TestProducts:
 
         app.dependency_overrides.clear()
 
-    def test_create_one(self, client, mocker, mock_session, mock_user):
+    def test_create_one(
+        self,
+        client,
+        mocker,
+        mock_session,
+    ):
         product_body = product_factory.product_body_factory(
             name='test product create')
         product_create = product_factory.product_create_factory(
@@ -154,11 +177,10 @@ class TestProducts:
         )
 
     def test_create_one_unauthorized(
-            self,
-            client,
-            mocker,
-            mock_session,
-            mock_user):
+        self,
+        client,
+        mocker,
+    ):
         def unauthorized():
             raise HTTPException(status_code=401)
         product_body = product_factory.product_body_factory(
@@ -174,13 +196,21 @@ class TestProducts:
 
         app.dependency_overrides.clear()
 
-    def test_update_one(self, client, mocker, mock_session, mock_user):
+    def test_update_one(
+        self,
+        client,
+        mocker,
+        mock_session,
+    ):
         product_body = product_factory.product_body_factory(
-            name='test product update')
+            name='test product update'
+        )
         product_update = product_factory.product_update_factory(
-            name='test product update')
+            name='test product update'
+        )
         product_result = product_factory.product_public_factory(
-            name='test product update')
+            name='test product update'
+        )
 
         mock = mocker.patch.object(
             service,
@@ -200,16 +230,17 @@ class TestProducts:
         )
 
     def test_update_one_notfound(
-            self,
-            client,
-            mocker,
-            mock_session,
-            mock_user):
+        self,
+        client,
+        mocker,
+        mock_session,
+    ):
         product_body = product_factory.product_body_factory(
-            name='test product update')
+            name='test product update'
+        )
         product_update = product_factory.product_update_factory(
-            name='test product update')
-        product_result = None
+            name='test product update'
+        )
 
         mock = mocker.patch.object(
             service,
@@ -218,7 +249,6 @@ class TestProducts:
         )
 
         response = client.put('/api/products/2', json=product_body)
-        response_data = response.json()
 
         assert response.status_code == 404
         mock.assert_called_once_with(
@@ -228,11 +258,10 @@ class TestProducts:
         )
 
     def test_update_one_unauthorized(
-            self,
-            client,
-            mocker,
-            mock_session,
-            mock_user):
+        self,
+        client,
+        mocker,
+    ):
         def unauthorized():
             raise HTTPException(status_code=401)
         product_body = product_factory.product_body_factory(
@@ -248,7 +277,12 @@ class TestProducts:
 
         app.dependency_overrides.clear()
 
-    def test_delete_one(self, client, mocker, mock_session, mock_user):
+    def test_delete_one(
+        self,
+        client,
+        mocker,
+        mock_session,
+    ):
         product_result = product_factory.product_public_factory(
             name='test product delete')
 
@@ -269,13 +303,11 @@ class TestProducts:
         )
 
     def test_delete_one_notfound(
-            self,
-            client,
-            mocker,
-            mock_session,
-            mock_user):
-        product_result = None
-
+        self,
+        client,
+        mocker,
+        mock_session,
+    ):
         mock = mocker.patch.object(
             service,
             'delete_one',
@@ -283,7 +315,6 @@ class TestProducts:
         )
 
         response = client.delete('/api/products/2')
-        response_data = response.json()
 
         assert response.status_code == 404
         mock.assert_called_once_with(
@@ -295,13 +326,9 @@ class TestProducts:
             self,
             client,
             mocker,
-            mock_session,
-            mock_user):
+        ):
         def unauthorized():
             raise HTTPException(status_code=401)
-        product_body = product_factory.product_body_factory(
-            name='test product delete')
-
         app.dependency_overrides[get_current_user] = unauthorized
 
         mock = mocker.patch('src.products.service.delete_one')