Mop/amap
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

fix all pylint warnings, add tests (wip) fix recap

Browse Source
This commit is contained in:
Julien Aldon
2026-03-06 00:00:01 +01:00
parent 60812652cf
commit b4b4fa7643
25 changed files with 845 additions and 376 deletions
Download Patch File Download Diff File Expand all files Collapse all files

151
backend/tests/routers/test_forms.py
View File

@@ -1,15 +1,20 @@
import src.forms.exceptions as forms_exceptions
import src.forms.service as service
import src.messages as messages
import tests.factories.forms as form_factory
from fastapi.exceptions import HTTPException
from src import models
from src import messages
from src.auth.auth import get_current_user
from src.main import app
class TestForms:
def test_get_all(self, client, mocker, mock_session, mock_user):
def test_get_all(
self,
client,
mocker,
mock_session,
mock_user,
):
mock_results = [
form_factory.form_public_factory(name="test 1", id=1),
form_factory.form_public_factory(name="test 2", id=2),
@@ -34,7 +39,13 @@ class TestForms:
mock_user,
)
def test_get_all_filters(self, client, mocker, mock_session, mock_user):
def test_get_all_filters(
self,
client,
mocker,
mock_session,
mock_user,
):
mock_results = [
form_factory.form_public_factory(name="test 2", id=2),
]
@@ -59,11 +70,10 @@ class TestForms:
)
def test_get_all_unauthorized(
self,
client,
mocker,
mock_session,
mock_user):
self,
client,
mocker,
):
def unauthorized():
raise HTTPException(status_code=401)
@@ -77,7 +87,12 @@ class TestForms:
app.dependency_overrides.clear()
def test_get_one(self, client, mocker, mock_session, mock_user):
def test_get_one(
self,
client,
mocker,
mock_session,
):
mock_result = form_factory.form_public_factory(name="test 2", id=2)
mock = mocker.patch.object(
@@ -96,7 +111,12 @@ class TestForms:
2
)
def test_get_one_notfound(self, client, mocker, mock_session, mock_user):
def test_get_one_notfound(
self,
client,
mocker,
mock_session,
):
mock_result = None
mock = mocker.patch.object(
service,
@@ -104,14 +124,18 @@ class TestForms:
return_value=mock_result
)
response = client.get('/api/forms/2')
response_data = response.json()
assert response.status_code == 404
mock.assert_called_once_with(
mock_session,
2
)
def test_create_one(self, client, mocker, mock_session, mock_user):
def test_create_one(
self,
client,
mocker,
mock_session,
):
form_body = form_factory.form_body_factory(name='test form create')
form_create = form_factory.form_create_factory(name='test form create')
form_result = form_factory.form_public_factory(name='test form create')
@@ -133,7 +157,11 @@ class TestForms:
)
def test_create_one_referer_notfound(
self, client, mocker, mock_session, mock_user):
self,
client,
mocker,
mock_session,
):
form_body = form_factory.form_body_factory(
name='test form create', referer_id=12312)
form_create = form_factory.form_create_factory(
@@ -144,8 +172,6 @@ class TestForms:
messages.Messages.not_found('referer')))
response = client.post('/api/forms', json=form_body)
response_data = response.json()
assert response.status_code == 404
mock.assert_called_once_with(
mock_session,
@@ -153,7 +179,11 @@ class TestForms:
)
def test_create_one_productor_notfound(
self, client, mocker, mock_session, mock_user):
self,
client,
mocker,
mock_session,
):
form_body = form_factory.form_body_factory(
name='test form create', productor_id=1231)
form_create = form_factory.form_create_factory(
@@ -164,7 +194,6 @@ class TestForms:
messages.Messages.not_found('productor')))
response = client.post('/api/forms', json=form_body)
response_data = response.json()
assert response.status_code == 404
mock.assert_called_once_with(
@@ -173,11 +202,10 @@ class TestForms:
)
def test_create_one_unauthorized(
self,
client,
mocker,
mock_session,
mock_user):
self,
client,
mocker,
):
def unauthorized():
raise HTTPException(status_code=401)
form_body = form_factory.form_body_factory(name='test form create')
@@ -192,7 +220,12 @@ class TestForms:
app.dependency_overrides.clear()
def test_update_one(self, client, mocker, mock_session, mock_user):
def test_update_one(
self,
client,
mocker,
mock_session,
):
form_body = form_factory.form_body_factory(name='test form update')
form_update = form_factory.form_update_factory(name='test form update')
form_result = form_factory.form_public_factory(name='test form update')
@@ -215,11 +248,11 @@ class TestForms:
)
def test_update_one_notfound(
self,
client,
mocker,
mock_session,
mock_user):
self,
client,
mocker,
mock_session,
):
form_body = form_factory.form_body_factory(name='test form update')
form_update = form_factory.form_update_factory(name='test form update')
@@ -228,7 +261,6 @@ class TestForms:
messages.Messages.not_found('form')))
response = client.put('/api/forms/2', json=form_body)
response_data = response.json()
assert response.status_code == 404
mock.assert_called_once_with(
@@ -238,7 +270,11 @@ class TestForms:
)
def test_update_one_referer_notfound(
self, client, mocker, mock_session, mock_user):
self,
client,
mocker,
mock_session,
):
form_body = form_factory.form_body_factory(name='test form update')
form_update = form_factory.form_update_factory(name='test form update')
@@ -247,7 +283,6 @@ class TestForms:
messages.Messages.not_found('referer')))
response = client.put('/api/forms/2', json=form_body)
response_data = response.json()
assert response.status_code == 404
mock.assert_called_once_with(
@@ -257,7 +292,11 @@ class TestForms:
)
def test_update_one_productor_notfound(
self, client, mocker, mock_session, mock_user):
self,
client,
mocker,
mock_session,
):
form_body = form_factory.form_body_factory(name='test form update')
form_update = form_factory.form_update_factory(name='test form update')
@@ -266,7 +305,6 @@ class TestForms:
messages.Messages.not_found('productor')))
response = client.put('/api/forms/2', json=form_body)
response_data = response.json()
assert response.status_code == 404
mock.assert_called_once_with(
@@ -276,11 +314,10 @@ class TestForms:
)
def test_update_one_unauthorized(
self,
client,
mocker,
mock_session,
mock_user):
self,
client,
mocker,
):
def unauthorized():
raise HTTPException(status_code=401)
form_body = form_factory.form_body_factory(name='test form update')
@@ -295,7 +332,12 @@ class TestForms:
app.dependency_overrides.clear()
def test_delete_one(self, client, mocker, mock_session, mock_user):
def test_delete_one(
self,
client,
mocker,
mock_session,
):
form_result = form_factory.form_public_factory(name='test form delete')
mock = mocker.patch.object(
@@ -315,19 +357,19 @@ class TestForms:
)
def test_delete_one_notfound(
self,
client,
mocker,
mock_session,
mock_user):
form_result = None
self,
client,
mocker,
mock_session,
):
mock = mocker.patch.object(
service, 'delete_one', side_effect=forms_exceptions.FormNotFoundError(
messages.Messages.not_found('form')))
service,
'delete_one',
side_effect=forms_exceptions.FormNotFoundError(
messages.Messages.not_found('form'))
)
response = client.delete('/api/forms/2')
response_data = response.json()
assert response.status_code == 404
mock.assert_called_once_with(
@@ -336,11 +378,10 @@ class TestForms:
)
def test_delete_one_unauthorized(
self,
client,
mocker,
mock_session,
mock_user):
self,
client,
mocker,
):
def unauthorized():
raise HTTPException(status_code=401)