fix pylint errors

backend/src/users/__init__.py

@@ -1,3 +1,3 @@
 # SPDX-FileCopyrightText: 2026-present Julien Aldon <julien.aldon@wanadoo.fr>
 #
-# SPDX-License-Identifier: MIT
+# SPDX-License-Identifier: MIT

backend/src/users/exceptions.py

@@ -1,11 +1,17 @@
+import logging
+
+
 class UserServiceError(Exception):
     def __init__(self, message: str):
         super().__init__(message)
+        logging.error('UserService : %s', message)
+
 
 class UserNotFoundError(UserServiceError):
     pass
 
+
 class UserCreateError(UserServiceError):
     def __init__(self, message: str, field: str | None = None):
         super().__init__(message)
-        self.field = field
+        self.field = field

backend/src/users/service.py

@@ -1,9 +1,8 @@
-from sqlmodel import Session, select
-
-import src.models as models
 import src.messages as messages
-
 import src.users.exceptions as exceptions
+from sqlmodel import Session, select
+from src import models
+
 
 def get_all(
     session: Session,
@@ -17,11 +16,15 @@ def get_all(
         statement = statement.where(models.User.email.in_(emails))
     return session.exec(statement.order_by(models.User.name)).all()
 
+
 def get_one(session: Session, user_id: int) -> models.UserPublic:
     return session.get(models.User, user_id)
 
-def get_or_create_roles(session: Session, role_names: list[str]) -> list[models.ContractType]:
-    statement = select(models.ContractType).where(models.ContractType.name.in_(role_names))
+
+def get_or_create_roles(session: Session,
+                        role_names: list[str]) -> list[models.ContractType]:
+    statement = select(models.ContractType).where(
+        models.ContractType.name.in_(role_names))
     existing = session.exec(statement).all()
     existing_roles = {role.name for role in existing}
     missing_role = set(role_names) - existing_roles
@@ -37,8 +40,11 @@ def get_or_create_roles(session: Session, role_names: list[str]) -> list[models.
         session.refresh(role)
     return existing + new_roles
 
+
 def get_or_create_user(session: Session, user_create: models.UserCreate):
-    statement = select(models.User).where(models.User.email == user_create.email)
+    statement = select(
+        models.User).where(
+        models.User.email == user_create.email)
     user = session.exec(statement).first()
     if user:
         user_role_names = [r.name for r in user.roles]
@@ -48,13 +54,17 @@ def get_or_create_user(session: Session, user_create: models.UserCreate):
     user = create_one(session, user_create)
     return user
 
+
 def get_roles(session: Session):
     statement = select(models.ContractType)
     return session.exec(statement.order_by(models.ContractType.name)).all()
 
+
 def create_one(session: Session, user: models.UserCreate) -> models.UserPublic:
     if user is None:
-        raise exceptions.UserCreateError(messages.Messages.invalid_input('user', 'input cannot be None'))
+        raise exceptions.UserCreateError(
+            messages.Messages.invalid_input(
+                'user', 'input cannot be None'))
     new_user = models.User(
         name=user.name,
         email=user.email
@@ -68,9 +78,15 @@ def create_one(session: Session, user: models.UserCreate) -> models.UserPublic:
     session.refresh(new_user)
     return new_user
 
-def update_one(session: Session, id: int, user: models.UserCreate) -> models.UserPublic:
+
+def update_one(
+        session: Session,
+        id: int,
+        user: models.UserCreate) -> models.UserPublic:
     if user is None:
-        raise exceptions.UserCreateError(messages.s.invalid_input('user', 'input cannot be None'))
+        raise exceptions.UserCreateError(
+            messages.s.invalid_input(
+                'user', 'input cannot be None'))
     statement = select(models.User).where(models.User.id == id)
     result = session.exec(statement)
     new_user = result.first()
@@ -86,6 +102,7 @@ def update_one(session: Session, id: int, user: models.UserCreate) -> models.Use
     session.refresh(new_user)
     return new_user
 
+
 def delete_one(session: Session, id: int) -> models.UserPublic:
     statement = select(models.User).where(models.User.id == id)
     result = session.exec(statement)
@@ -95,4 +112,4 @@ def delete_one(session: Session, id: int) -> models.UserPublic:
     result = models.UserPublic.model_validate(user)
     session.delete(user)
     session.commit()
-    return result
+    return result

backend/src/users/users.py

@@ -1,14 +1,15 @@
-from fastapi import APIRouter, HTTPException, Depends, Query
 import src.messages as messages
-import src.models as models
-from src.database import get_session
-from sqlmodel import Session
-import src.users.service as service
-from src.auth.auth import get_current_user
 import src.users.exceptions as exceptions
+import src.users.service as service
+from fastapi import APIRouter, Depends, HTTPException, Query
+from sqlmodel import Session
+from src import models
+from src.auth.auth import get_current_user
+from src.database import get_session
 
 router = APIRouter(prefix='/users')
 
+
 @router.get('', response_model=list[models.UserPublic])
 def get_users(
     session: Session = Depends(get_session),
@@ -22,6 +23,7 @@ def get_users(
         emails,
     )
 
+
 @router.get('/roles', response_model=list[models.ContractType])
 def get_roles(
     user: models.User = Depends(get_current_user),
@@ -29,20 +31,23 @@ def get_roles(
 ):
     return service.get_roles(session)
 
+
 @router.get('/{id}', response_model=models.UserPublic)
 def get_users(
-    id: int, 
+    id: int,
     user: models.User = Depends(get_current_user),
     session: Session = Depends(get_session)
 ):
     result = service.get_one(session, id)
     if result is None:
-        raise HTTPException(status_code=404, detail=messages.Messages.not_found('user'))
+        raise HTTPException(status_code=404,
+                            detail=messages.Messages.not_found('user'))
     return result
 
+
 @router.post('', response_model=models.UserPublic)
 def create_user(
-    user: models.UserCreate, 
+    user: models.UserCreate,
     logged_user: models.User = Depends(get_current_user),
     session: Session = Depends(get_session)
 ):
@@ -52,27 +57,31 @@ def create_user(
         raise HTTPException(status_code=400, detail=str(error))
     return user
 
+
 @router.put('/{id}', response_model=models.UserPublic)
 def update_user(
-    id: int, 
-    user: models.UserUpdate, 
+    id: int,
+    user: models.UserUpdate,
     logged_user: models.User = Depends(get_current_user),
     session: Session = Depends(get_session)
 ):
     try:
         result = service.update_one(session, id, user)
     except exceptions.UserNotFoundError as error:
-        raise HTTPException(status_code=404, detail=messages.Messages.not_found('user'))
+        raise HTTPException(status_code=404,
+                            detail=messages.Messages.not_found('user'))
     return result
 
+
 @router.delete('/{id}', response_model=models.UserPublic)
 def delete_user(
-    id: int, 
+    id: int,
     user: models.User = Depends(get_current_user),
     session: Session = Depends(get_session)
 ):
     try:
         result = service.delete_one(session, id)
     except exceptions.UserNotFoundError as error:
-        raise HTTPException(status_code=404, detail=messages.Messages.not_found('user'))
+        raise HTTPException(status_code=404,
+                            detail=messages.Messages.not_found('user'))
     return result