fix test format

2026-03-02 16:33:52 +01:00
parent 5dd9e19877
commit 0e48d1bbaa
20 changed files with 751 additions and 436 deletions
--- a/backend/tests/routers/test_forms.py
+++ b/backend/tests/routers/test_forms.py
@@ -7,6 +7,7 @@ import tests.factories.forms as form_factory
 from fastapi.exceptions import HTTPException
 import src.messages as messages

+
 class TestForms:
    def test_get_all(self, client, mocker, mock_session, mock_user):
        mock_results = [
@@ -32,6 +33,7 @@ class TestForms:
            False,
            mock_user,
        )
+
    def test_get_all_filters(self, client, mocker, mock_session, mock_user):
        mock_results = [
            form_factory.form_public_factory(name="test 2", id=2),
@@ -42,7 +44,8 @@ class TestForms:
            return_value=mock_results
        )

-        response = client.get('/api/forms/referents?current_season=true&seasons=hiver-2025&productors=test productor')
+        response = client.get(
+            '/api/forms/referents?current_season=true&seasons=hiver-2025&productors=test productor')
        response_data = response.json()
        assert response.status_code == 200
        assert response_data[0]['id'] == 2
@@ -55,10 +58,15 @@ class TestForms:
            mock_user,
        )

-    def test_get_all_unauthorized(self, client, mocker, mock_session, mock_user):
+    def test_get_all_unauthorized(
+            self,
+            client,
+            mocker,
+            mock_session,
+            mock_user):
        def unauthorized():
            raise HTTPException(status_code=401)
-            
+
        app.dependency_overrides[get_current_user] = unauthorized

        mock = mocker.patch('src.forms.service.get_all')
@@ -87,7 +95,7 @@ class TestForms:
            mock_session,
            2
        )
-    
+
    def test_get_one_notfound(self, client, mocker, mock_session, mock_user):
        mock_result = None
        mock = mocker.patch.object(
@@ -102,8 +110,7 @@ class TestForms:
            mock_session,
            2
        )
-    
-    
+
    def test_create_one(self, client, mocker, mock_session, mock_user):
        form_body = form_factory.form_body_factory(name='test form create')
        form_create = form_factory.form_create_factory(name='test form create')
@@ -124,16 +131,17 @@ class TestForms:
            mock_session,
            form_create
        )
-    
-    def test_create_one_referer_notfound(self, client, mocker, mock_session, mock_user):
-        form_body = form_factory.form_body_factory(name='test form create', referer_id=12312)
-        form_create = form_factory.form_create_factory(name='test form create', referer_id=12312)
+
+    def test_create_one_referer_notfound(
+            self, client, mocker, mock_session, mock_user):
+        form_body = form_factory.form_body_factory(
+            name='test form create', referer_id=12312)
+        form_create = form_factory.form_create_factory(
+            name='test form create', referer_id=12312)

        mock = mocker.patch.object(
-            service,
-            'create_one',
-            side_effect=forms_exceptions.UserNotFoundError(messages.Messages.not_found('referer'))
-        )
+            service, 'create_one', side_effect=forms_exceptions.UserNotFoundError(
+                messages.Messages.not_found('referer')))

        response = client.post('/api/forms', json=form_body)
        response_data = response.json()
@@ -144,15 +152,16 @@ class TestForms:
            form_create
        )

-    def test_create_one_productor_notfound(self, client, mocker, mock_session, mock_user):
-        form_body = form_factory.form_body_factory(name='test form create', productor_id=1231)
-        form_create = form_factory.form_create_factory(name='test form create', productor_id=1231)
+    def test_create_one_productor_notfound(
+            self, client, mocker, mock_session, mock_user):
+        form_body = form_factory.form_body_factory(
+            name='test form create', productor_id=1231)
+        form_create = form_factory.form_create_factory(
+            name='test form create', productor_id=1231)

        mock = mocker.patch.object(
-            service,
-            'create_one',
-            side_effect=forms_exceptions.ProductorNotFoundError(messages.Messages.not_found('productor'))
-        )
+            service, 'create_one', side_effect=forms_exceptions.ProductorNotFoundError(
+                messages.Messages.not_found('productor')))

        response = client.post('/api/forms', json=form_body)
        response_data = response.json()
@@ -163,11 +172,16 @@ class TestForms:
            form_create
        )

-    def test_create_one_unauthorized(self, client, mocker, mock_session, mock_user):
+    def test_create_one_unauthorized(
+            self,
+            client,
+            mocker,
+            mock_session,
+            mock_user):
        def unauthorized():
            raise HTTPException(status_code=401)
        form_body = form_factory.form_body_factory(name='test form create')
-            
+
        app.dependency_overrides[get_current_user] = unauthorized

        mock = mocker.patch('src.forms.service.create_one')
@@ -200,35 +214,18 @@ class TestForms:
            form_update
        )

-    def test_update_one_notfound(self, client, mocker, mock_session, mock_user):
-        form_body = form_factory.form_body_factory(name='test form update')
-        form_update = form_factory.form_update_factory(name='test form update')
-
-        mock = mocker.patch.object(
-            service,
-            'update_one',
-            side_effect=forms_exceptions.FormNotFoundError(messages.Messages.not_found('form'))
-        )
-
-        response = client.put('/api/forms/2', json=form_body)
-        response_data = response.json()
-
-        assert response.status_code == 404
-        mock.assert_called_once_with(
+    def test_update_one_notfound(
+            self,
+            client,
+            mocker,
            mock_session,
-            2,
-            form_update
-        )
-    
-    def test_update_one_referer_notfound(self, client, mocker, mock_session, mock_user):
+            mock_user):
        form_body = form_factory.form_body_factory(name='test form update')
        form_update = form_factory.form_update_factory(name='test form update')

        mock = mocker.patch.object(
-            service,
-            'update_one',
-            side_effect=forms_exceptions.UserNotFoundError(messages.Messages.not_found('referer'))
-        )
+            service, 'update_one', side_effect=forms_exceptions.FormNotFoundError(
+                messages.Messages.not_found('form')))

        response = client.put('/api/forms/2', json=form_body)
        response_data = response.json()
@@ -240,15 +237,14 @@ class TestForms:
            form_update
        )

-    def test_update_one_productor_notfound(self, client, mocker, mock_session, mock_user):
+    def test_update_one_referer_notfound(
+            self, client, mocker, mock_session, mock_user):
        form_body = form_factory.form_body_factory(name='test form update')
        form_update = form_factory.form_update_factory(name='test form update')

        mock = mocker.patch.object(
-            service,
-            'update_one',
-            side_effect=forms_exceptions.ProductorNotFoundError(messages.Messages.not_found('productor'))
-        )
+            service, 'update_one', side_effect=forms_exceptions.UserNotFoundError(
+                messages.Messages.not_found('referer')))

        response = client.put('/api/forms/2', json=form_body)
        response_data = response.json()
@@ -260,11 +256,35 @@ class TestForms:
            form_update
        )

-    def test_update_one_unauthorized(self, client, mocker, mock_session, mock_user):
+    def test_update_one_productor_notfound(
+            self, client, mocker, mock_session, mock_user):
+        form_body = form_factory.form_body_factory(name='test form update')
+        form_update = form_factory.form_update_factory(name='test form update')
+
+        mock = mocker.patch.object(
+            service, 'update_one', side_effect=forms_exceptions.ProductorNotFoundError(
+                messages.Messages.not_found('productor')))
+
+        response = client.put('/api/forms/2', json=form_body)
+        response_data = response.json()
+
+        assert response.status_code == 404
+        mock.assert_called_once_with(
+            mock_session,
+            2,
+            form_update
+        )
+
+    def test_update_one_unauthorized(
+            self,
+            client,
+            mocker,
+            mock_session,
+            mock_user):
        def unauthorized():
            raise HTTPException(status_code=401)
        form_body = form_factory.form_body_factory(name='test form update')
-            
+
        app.dependency_overrides[get_current_user] = unauthorized

        mock = mocker.patch('src.forms.service.update_one')
@@ -294,14 +314,17 @@ class TestForms:
            2,
        )

-    def test_delete_one_notfound(self, client, mocker, mock_session, mock_user):
+    def test_delete_one_notfound(
+            self,
+            client,
+            mocker,
+            mock_session,
+            mock_user):
        form_result = None

        mock = mocker.patch.object(
-            service,
-            'delete_one',
-            side_effect=forms_exceptions.FormNotFoundError(messages.Messages.not_found('form'))
-        )
+            service, 'delete_one', side_effect=forms_exceptions.FormNotFoundError(
+                messages.Messages.not_found('form')))

        response = client.delete('/api/forms/2')
        response_data = response.json()
@@ -312,10 +335,15 @@ class TestForms:
            2,
        )

-    def test_delete_one_unauthorized(self, client, mocker, mock_session, mock_user):
+    def test_delete_one_unauthorized(
+            self,
+            client,
+            mocker,
+            mock_session,
+            mock_user):
        def unauthorized():
            raise HTTPException(status_code=401)
-            
+
        app.dependency_overrides[get_current_user] = unauthorized

        mock = mocker.patch('src.forms.service.delete_one')
@@ -324,4 +352,4 @@ class TestForms:
        assert response.status_code == 401
        mock.assert_not_called()

-        app.dependency_overrides.clear()
+        app.dependency_overrides.clear()